From 83292b14c267242d37552f0e4c248e686de1159a Mon Sep 17 00:00:00 2001 From: Manuel Friedli Date: Fri, 31 Aug 2018 23:38:22 +0200 Subject: [PATCH] Fixed DectoBinConverter file name and added tests. --- src/app/converter-registry.service.ts | 2 +- src/app/converter/dec-to-bin-converter.spec.ts | 16 ++++++++++++++++ ...tobinconverter.ts => dec-to-bin-converter.ts} | 0 3 files changed, 17 insertions(+), 1 deletion(-) create mode 100644 src/app/converter/dec-to-bin-converter.spec.ts rename src/app/converter/{dectobinconverter.ts => dec-to-bin-converter.ts} (100%) diff --git a/src/app/converter-registry.service.ts b/src/app/converter-registry.service.ts index dc6699d..b4bef71 100644 --- a/src/app/converter-registry.service.ts +++ b/src/app/converter-registry.service.ts @@ -2,7 +2,7 @@ import {Base64Decoder} from './converter/base64-decoder'; import {Base64Encoder} from './converter/base64-encoder'; import {BinToDecConverter} from './converter/bin-to-dec-converter'; import {Converter} from './converter/converter'; -import {DecToBinConverter} from './converter/dectobinconverter'; +import {DecToBinConverter} from './converter/dec-to-bin-converter'; import {DecToHexConverter} from './converter/dectohexconverter'; import {HexToDecConverter} from './converter/hextodecconverter'; import {HTMLEntitiesDecoder} from './converter/htmlentitiesdecoder'; diff --git a/src/app/converter/dec-to-bin-converter.spec.ts b/src/app/converter/dec-to-bin-converter.spec.ts new file mode 100644 index 0000000..0305779 --- /dev/null +++ b/src/app/converter/dec-to-bin-converter.spec.ts @@ -0,0 +1,16 @@ +import {DecToBinConverter} from './dec-to-bin-converter'; + +describe('DecToBinConverter', () => { + it('should create an instance', () => { + expect(new DecToBinConverter()).toBeTruthy(); + }); + it('should have the id "base64encode"', () => { + expect(new DecToBinConverter().getId()).toEqual('dectobin'); + }); + it('should convert "22" to "10110"', () => { + expect(new DecToBinConverter().convert('22')).toEqual('10110'); + }); + it('should raise an exception on invalid input', () => { + expect(() => new DecToBinConverter().convert('foo bar')).toThrowError('The input seems not to be a valid integer.'); + }); +}); diff --git a/src/app/converter/dectobinconverter.ts b/src/app/converter/dec-to-bin-converter.ts similarity index 100% rename from src/app/converter/dectobinconverter.ts rename to src/app/converter/dec-to-bin-converter.ts