From e8f5d12fda245dc344af0070d35519138c6fc9b0 Mon Sep 17 00:00:00 2001 From: Manuel Friedli Date: Fri, 31 Aug 2018 23:40:47 +0200 Subject: [PATCH] Fixed DecToHexConverter filename, added test and fixed other tests. --- src/app/converter-registry.service.ts | 2 +- src/app/converter/bin-to-dec-converter.spec.ts | 2 +- src/app/converter/dec-to-bin-converter.spec.ts | 2 +- src/app/converter/dec-to-hex-converter.spec.ts | 16 ++++++++++++++++ ...tohexconverter.ts => dec-to-hex-converter.ts} | 0 5 files changed, 19 insertions(+), 3 deletions(-) create mode 100644 src/app/converter/dec-to-hex-converter.spec.ts rename src/app/converter/{dectohexconverter.ts => dec-to-hex-converter.ts} (100%) diff --git a/src/app/converter-registry.service.ts b/src/app/converter-registry.service.ts index b4bef71..4df04c0 100644 --- a/src/app/converter-registry.service.ts +++ b/src/app/converter-registry.service.ts @@ -3,7 +3,7 @@ import {Base64Encoder} from './converter/base64-encoder'; import {BinToDecConverter} from './converter/bin-to-dec-converter'; import {Converter} from './converter/converter'; import {DecToBinConverter} from './converter/dec-to-bin-converter'; -import {DecToHexConverter} from './converter/dectohexconverter'; +import {DecToHexConverter} from './converter/dec-to-hex-converter'; import {HexToDecConverter} from './converter/hextodecconverter'; import {HTMLEntitiesDecoder} from './converter/htmlentitiesdecoder'; import {HTMLEntitiesEncoder} from './converter/htmlentitiesencoder'; diff --git a/src/app/converter/bin-to-dec-converter.spec.ts b/src/app/converter/bin-to-dec-converter.spec.ts index 04dabd0..cf65375 100644 --- a/src/app/converter/bin-to-dec-converter.spec.ts +++ b/src/app/converter/bin-to-dec-converter.spec.ts @@ -4,7 +4,7 @@ describe('BinToDecConverter', () => { it('should create an instance', () => { expect(new BinToDecConverter()).toBeTruthy(); }); - it('should have the id "base64encode"', () => { + it('should have the id "bintodec"', () => { expect(new BinToDecConverter().getId()).toEqual('bintodec'); }); it('should convert "11011" to "27"', () => { diff --git a/src/app/converter/dec-to-bin-converter.spec.ts b/src/app/converter/dec-to-bin-converter.spec.ts index 0305779..e32fa18 100644 --- a/src/app/converter/dec-to-bin-converter.spec.ts +++ b/src/app/converter/dec-to-bin-converter.spec.ts @@ -4,7 +4,7 @@ describe('DecToBinConverter', () => { it('should create an instance', () => { expect(new DecToBinConverter()).toBeTruthy(); }); - it('should have the id "base64encode"', () => { + it('should have the id "dectobin"', () => { expect(new DecToBinConverter().getId()).toEqual('dectobin'); }); it('should convert "22" to "10110"', () => { diff --git a/src/app/converter/dec-to-hex-converter.spec.ts b/src/app/converter/dec-to-hex-converter.spec.ts new file mode 100644 index 0000000..152612f --- /dev/null +++ b/src/app/converter/dec-to-hex-converter.spec.ts @@ -0,0 +1,16 @@ +import {DecToHexConverter} from './dec-to-hex-converter'; + +describe('DecToHexConverter', () => { + it('should create an instance', () => { + expect(new DecToHexConverter()).toBeTruthy(); + }); + it('should have the id "dectohex"', () => { + expect(new DecToHexConverter().getId()).toEqual('dectohex'); + }); + it('should convert "22" to "16"', () => { + expect(new DecToHexConverter().convert('22')).toEqual('16'); + }); + it('should raise an exception on invalid input', () => { + expect(() => new DecToHexConverter().convert('foo bar')).toThrowError('The input seems not to be a valid integer.'); + }); +}); diff --git a/src/app/converter/dectohexconverter.ts b/src/app/converter/dec-to-hex-converter.ts similarity index 100% rename from src/app/converter/dectohexconverter.ts rename to src/app/converter/dec-to-hex-converter.ts