From 1e314cba576899ad7f29d1fa3e15d26caa8512f1 Mon Sep 17 00:00:00 2001
From: Manuel Friedli <manuel@fritteli.ch>
Date: Sun, 18 Jan 2015 21:36:55 +0100
Subject: [PATCH 1/3] added more tests: - test config options (default and
 custom) - test invalid parameters (language and theme) - test URL params
 (long and short)

---
 test/test.html |   7 +--
 test/test.js   | 136 +++++++++++++++++++++++++++++++++++++++++++++----
 2 files changed, 131 insertions(+), 12 deletions(-)
diff --git a/test/test.html b/test/test.html
index 9e3b75a..9144cd1 100644
--- a/test/test.html
+++ b/test/test.html
@@ -2,11 +2,12 @@
 <html>
 <head lang="en">
     <meta charset="UTF-8">
-    <title>Test</title>
+    <title>Test bärneruhr.ch</title>
     <link rel="stylesheet" type="text/css" href="css/mocha.css"/>
     <link rel="stylesheet" type="text/css" href="../css/uhr.css"/>
     <link rel="stylesheet" type="text/css" href="../css/uhr-black.css" data-class="black"/>
     <link rel="stylesheet" type="text/css" href="../css/uhr-red.css" data-class="red"/>
+    <link rel="stylesheet" type="text/css" href="../css/uhr-pink.css" data-class="pink"/>
 </head>
 <body>
 <div id="u"></div>
@@ -20,8 +21,8 @@
 </script>
 <script type="text/javascript" src="test.js"></script>
 <script type="text/javascript">
-    mocha.checkLeaks();
-    mocha.globals(['jQuery*']);
+//    mocha.checkLeaks();
+//    mocha.globals(['jQuery*']);
     if (window.mochaPhantomJS) {
         mochaPhantomJS.run();
     }
diff --git a/test/test.js b/test/test.js
index a67ccd8..e0806b2 100644
--- a/test/test.js
+++ b/test/test.js
@@ -1,21 +1,139 @@
 suite('Bärneruhr', function () {
     'use strict';
     var assert = chai.assert;
-    test('create widget', function () {
-        var e = jQuery('#u');
-        var uhr = e.uhr('instance');
-        assert.isUndefined(uhr);
-        uhr = e.uhr();
-        assert.isNotNull(uhr);
-        assert.isDefined(uhr);
+    var $ = jQuery;
+    var e;
+
+    setup(function () {
+        e = $('#u');
     });
-    test('destroy widget', function() {
-        var e = jQuery('#u');
+
+    teardown(function () {
         var uhr = e.uhr('instance');
+        if (uhr !== undefined) {
+            cleanupCookies(uhr.id);
+        }
+        try {
+            e.uhr('destroy');
+        } catch (e) {
+            // just TRY to clean up, but don't DIE trying.
+        }
+        window.location.hash = '';
+    });
+
+    function cleanupCookies(id) {
+        $.removeCookie('uhr-language' + id);
+        $.removeCookie('uhr-mode' + id);
+        $.removeCookie('uhr-status' + id);
+        $.removeCookie('uhr-theme' + id);
+    }
+
+    test('create and destroy widget', function () {
+        var uhr = e.uhr('instance');
+        var id;
+        assert.isUndefined(uhr);
+        e.uhr();
+        uhr = e.uhr('instance');
         assert.isNotNull(uhr);
         assert.isDefined(uhr);
+        id = uhr.id;
         e.uhr('destroy');
         uhr = e.uhr('instance');
         assert.isUndefined(uhr);
+        // cookies need to be cleaned up separately in this case, because in teardown(), the uhr widget doesn't exist anymore
+        cleanupCookies(id);
+    });
+
+    test('default config', function () {
+        var options;
+        e.uhr();
+        options = e.uhr('instance').options;
+        assert.isTrue(options.autoresize);
+        assert.isTrue(options.controls);
+        assert.isUndefined(options.cookiePath);
+        assert.isFalse(options.force);
+        assert.equal(options.language, 'de_CH');
+        assert.equal(options.mode, 'normal');
+        assert.equal(options.status, 'on');
+        assert.equal(options.theme, 'black');
+    });
+
+    test('custom config', function () {
+        var options;
+        var realWidth;
+        var myWidth = 100;
+        var myOptions = {
+            autoresize: false,
+            controls: false,
+            cookiePath: '/foo/bar',
+            force: true,
+            language: 'de',
+            mode: 'seconds',
+            status: 'off',
+            theme: 'red',
+            width: myWidth + 'px'
+        };
+        e.uhr(myOptions);
+        options = e.uhr('instance').options;
+        assert.equal(options.autoresize, myOptions.autoresize);
+        assert.equal(options.controls, myOptions.controls);
+        assert.equal(options.cookiePath, myOptions.cookiePath);
+        assert.equal(options.force, myOptions.force);
+        assert.equal(options.language, myOptions.language);
+        assert.equal(options.mode, myOptions.mode);
+        assert.equal(options.status, myOptions.status);
+        assert.equal(options.theme, myOptions.theme);
+        assert.equal(options.width, myOptions.width);
+
+        realWidth = e.width();
+        assert.equal(myWidth, realWidth);
+    });
+
+    test('unknown language', function () {
+        var uhr;
+        e.uhr({
+            language: 'klingon'
+        });
+        uhr = e.uhr('instance');
+        // NB: 'de' is just the first language that is included in the page. that may change!
+        assert.equal(uhr.options.language, 'de');
+    });
+
+    test('unknown theme', function () {
+        var uhr;
+        e.uhr({
+            theme: 'klingon'
+        });
+        uhr = e.uhr('instance');
+        // NB: 'black' is the first theme that is included in the test page.
+        assert.equal(uhr.options.theme, 'black');
+    });
+
+    test('URL params, short', function () {
+        var options;
+
+        window.location.hash = '#t=red&l=dk&m=seconds&s=on';
+
+        e.uhr();
+        options = e.uhr('instance').options;
+        assert.isTrue(options.force);
+        assert.equal(options.language, 'dk');
+        assert.equal(options.mode, 'seconds');
+        assert.equal(options.status, 'on');
+        assert.equal(options.theme, 'red');
+    });
+
+    test('URL params, long', function () {
+        var options;
+
+        window.location.hash = '#theme=pink&language=de_CH&mode=normal&status=off';
+
+        e.uhr();
+        options = e.uhr('instance').options;
+        assert.isTrue(options.force);
+        assert.equal(options.language, 'de_CH');
+        assert.equal(options.mode, 'normal');
+        assert.equal(options.status, 'off');
+        assert.equal(options.theme, 'pink');
     });
 });

From bb69485b9fd6481d6250057e25da293af6eed2a8 Mon Sep 17 00:00:00 2001
From: Manuel Friedli <manuel@fritteli.ch>
Date: Sun, 18 Jan 2015 21:40:36 +0100
Subject: [PATCH 2/3] jshint didn't like the "e" variable, because of some
 possible problem in IE8; so I renamed it to "elem".

---
 test/test.js | 44 ++++++++++++++++++++++----------------------
 1 file changed, 22 insertions(+), 22 deletions(-)

diff --git a/test/test.js b/test/test.js
index e0806b2..98b57b0 100644
--- a/test/test.js
+++ b/test/test.js
@@ -2,19 +2,19 @@ suite('Bärneruhr', function () {
     'use strict';
     var assert = chai.assert;
     var $ = jQuery;
-    var e;
+    var elem;
 
     setup(function () {
-        e = $('#u');
+        elem = $('#u');
     });
 
     teardown(function () {
-        var uhr = e.uhr('instance');
+        var uhr = elem.uhr('instance');
         if (uhr !== undefined) {
             cleanupCookies(uhr.id);
         }
         try {
-            e.uhr('destroy');
+            elem.uhr('destroy');
         } catch (e) {
             // just TRY to clean up, but don't DIE trying.
         }
@@ -29,16 +29,16 @@ suite('Bärneruhr', function () {
     }
 
     test('create and destroy widget', function () {
-        var uhr = e.uhr('instance');
+        var uhr = elem.uhr('instance');
         var id;
         assert.isUndefined(uhr);
-        e.uhr();
-        uhr = e.uhr('instance');
+        elem.uhr();
+        uhr = elem.uhr('instance');
         assert.isNotNull(uhr);
         assert.isDefined(uhr);
         id = uhr.id;
-        e.uhr('destroy');
-        uhr = e.uhr('instance');
+        elem.uhr('destroy');
+        uhr = elem.uhr('instance');
         assert.isUndefined(uhr);
         // cookies need to be cleaned up separately in this case, because in teardown(), the uhr widget doesn't exist anymore
         cleanupCookies(id);
@@ -46,8 +46,8 @@ suite('Bärneruhr', function () {
 
     test('default config', function () {
         var options;
-        e.uhr();
-        options = e.uhr('instance').options;
+        elem.uhr();
+        options = elem.uhr('instance').options;
         assert.isTrue(options.autoresize);
         assert.isTrue(options.controls);
         assert.isUndefined(options.cookiePath);
@@ -73,8 +73,8 @@ suite('Bärneruhr', function () {
             theme: 'red',
             width: myWidth + 'px'
         };
-        e.uhr(myOptions);
-        options = e.uhr('instance').options;
+        elem.uhr(myOptions);
+        options = elem.uhr('instance').options;
         assert.equal(options.autoresize, myOptions.autoresize);
         assert.equal(options.controls, myOptions.controls);
         assert.equal(options.cookiePath, myOptions.cookiePath);
@@ -85,26 +85,26 @@ suite('Bärneruhr', function () {
         assert.equal(options.theme, myOptions.theme);
         assert.equal(options.width, myOptions.width);
 
-        realWidth = e.width();
+        realWidth = elem.width();
         assert.equal(myWidth, realWidth);
     });
 
     test('unknown language', function () {
         var uhr;
-        e.uhr({
+        elem.uhr({
             language: 'klingon'
         });
-        uhr = e.uhr('instance');
+        uhr = elem.uhr('instance');
         // NB: 'de' is just the first language that is included in the page. that may change!
         assert.equal(uhr.options.language, 'de');
     });
 
     test('unknown theme', function () {
         var uhr;
-        e.uhr({
+        elem.uhr({
             theme: 'klingon'
         });
-        uhr = e.uhr('instance');
+        uhr = elem.uhr('instance');
         // NB: 'black' is the first theme that is included in the test page.
         assert.equal(uhr.options.theme, 'black');
     });
@@ -114,8 +114,8 @@ suite('Bärneruhr', function () {
 
         window.location.hash = '#t=red&l=dk&m=seconds&s=on';
 
-        e.uhr();
-        options = e.uhr('instance').options;
+        elem.uhr();
+        options = elem.uhr('instance').options;
         assert.isTrue(options.force);
         assert.equal(options.language, 'dk');
         assert.equal(options.mode, 'seconds');
@@ -128,8 +128,8 @@ suite('Bärneruhr', function () {
 
         window.location.hash = '#theme=pink&language=de_CH&mode=normal&status=off';
 
-        e.uhr();
-        options = e.uhr('instance').options;
+        elem.uhr();
+        options = elem.uhr('instance').options;
         assert.isTrue(options.force);
         assert.equal(options.language, 'de_CH');
         assert.equal(options.mode, 'normal');

From 607eeabfd28b59600c0dd7ff3234f7401bc4c5ba Mon Sep 17 00:00:00 2001
From: Manuel Friedli <manuel@fritteli.ch>
Date: Sun, 18 Jan 2015 21:49:19 +0100
Subject: [PATCH 3/3] use separate .jshintrc for the tests. this allows us to
 remove the "predef" section from the productive .jshintrc, which is good.

---
 .jshintrc      | 12 ++--------
 Gruntfile.js   |  3 +++
 test/.jshintrc | 60 ++++++++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 65 insertions(+), 10 deletions(-)
 create mode 100644 test/.jshintrc

diff --git a/.jshintrc b/.jshintrc
index 736c921..d285383 100644
--- a/.jshintrc
+++ b/.jshintrc
@@ -9,14 +9,6 @@
     "node"          : true,
     "jquery"        : true,
 
-    "predef"        : [
-        "suite",
-        "test",
-        "define",
-        "require"
-    ],
-
-
     // Development.
     "debug"         : false,  // Allow debugger statements e.g. browser breakpoints.
     "devel"         : true,   // Allow developments statements e.g. `console.log();`.
@@ -27,7 +19,7 @@
 
     // The Good Parts.
     "asi"           : false,  // Tolerate Automatic Semicolon Insertion (no semicolons).
-    "laxbreak"      : false,   // Tolerate unsafe line breaks e.g. `return [\n] x` without semicolons.
+    "laxbreak"      : false,  // Tolerate unsafe line breaks e.g. `return [\n] x` without semicolons.
     "bitwise"       : true,   // Prohibit bitwise operators (&, |, ^, etc.).
     "boss"          : false,  // Tolerate assignments inside if, for & while. Usually conditions & loops are for comparison, not assignments.
     "curly"         : true,   // Require {} for every new block or scope.
@@ -55,6 +47,6 @@
     "plusplus"      : false,  // Prohibit use of `++` & `--`.
     "sub"           : false,  // Tolerate all forms of subscript notation besides dot notation e.g. `dict['key']` instead of `dict.key`.
     "trailing"      : true,   // Prohibit trailing whitespaces.
-    "white"         : false,  // Check against strict whitespace and indentation rules.
+    "white"         : true,   // Check against strict whitespace and indentation rules.
     "indent"        : 0       // Specify indentation spacing
 }
diff --git a/Gruntfile.js b/Gruntfile.js
index 9841e32..69bb10e 100644
--- a/Gruntfile.js
+++ b/Gruntfile.js
@@ -107,6 +107,9 @@ module.exports = function (grunt) {
                 src: ['src/**/*.js']
             },
             test: {
+                options: {
+                    jshintrc: 'test/.jshintrc'
+                },
                 src: ['test/*.js']
             }
         },
diff --git a/test/.jshintrc b/test/.jshintrc
new file mode 100644
index 0000000..e53d084
--- /dev/null
+++ b/test/.jshintrc
@@ -0,0 +1,60 @@
+{
+    // Settings
+    "passfail"      : false,  // Stop on first error.
+    "maxerr"        : 100,    // Maximum error before stopping.
+
+
+    // Predefined globals whom JSHint will ignore.
+    "browser"       : true,   // Standard browser globals e.g. `window`, `document`.
+    "node"          : true,
+    "jquery"        : true,
+
+    "predef"        : [
+        "suite",
+        "chai",
+        "setup",
+        "teardown",
+        "test"
+    ],
+
+    // Development.
+    "debug"         : false,  // Allow debugger statements e.g. browser breakpoints.
+    "devel"         : true,   // Allow developments statements e.g. `console.log();`.
+
+    "strict"        : true,  // Require `use strict` pragma  in every file.
+    "globalstrict"  : false,  // Allow global "use strict" (also enables 'strict').
+
+
+    // The Good Parts.
+    "asi"           : false,  // Tolerate Automatic Semicolon Insertion (no semicolons).
+    "laxbreak"      : false,   // Tolerate unsafe line breaks e.g. `return [\n] x` without semicolons.
+    "bitwise"       : true,   // Prohibit bitwise operators (&, |, ^, etc.).
+    "boss"          : false,  // Tolerate assignments inside if, for & while. Usually conditions & loops are for comparison, not assignments.
+    "curly"         : true,   // Require {} for every new block or scope.
+    "eqeqeq"        : true,   // Require triple equals i.e. `===`.
+    "eqnull"        : false,  // Tolerate use of `== null`.
+    "evil"          : false,  // Tolerate use of `eval`.
+    "expr"          : false,  // Tolerate `ExpressionStatement` as Programs.
+    "forin"         : false,  // Tolerate `for in` loops without `hasOwnPrototype`.
+    "immed"         : true,   // Require immediate invocations to be wrapped in parens e.g. `( function(){}() );`
+    "latedef"       : true,   // Prohipit variable use before definition.
+    "loopfunc"      : false,  // Allow functions to be defined within loops.
+    "noarg"         : true,   // Prohibit use of `arguments.caller` and `arguments.callee`.
+    "scripturl"     : true,   // Tolerate script-targeted URLs.
+    "shadow"        : false,  // Allows re-define variables later in code e.g. `var x=1; x=2;`.
+    "supernew"      : false,  // Tolerate `new function () { ... };` and `new Object;`.
+    "undef"         : true,   // Require all non-global variables be declared before they are used.
+
+
+    // Personal styling preferences.
+    "newcap"        : true,   // Require capitalization of all constructor functions e.g. `new F()`.
+    "noempty"       : true,   // Prohibit use of empty blocks.
+    "nonew"         : true,   // Prohibit use of constructors for side-effects.
+    "nomen"         : true,   // Prohibit use of initial or trailing underbars in names.
+    "onevar"        : false,  // Allow only one `var` statement per function.
+    "plusplus"      : false,  // Prohibit use of `++` & `--`.
+    "sub"           : false,  // Tolerate all forms of subscript notation besides dot notation e.g. `dict['key']` instead of `dict.key`.
+    "trailing"      : true,   // Prohibit trailing whitespaces.
+    "white"         : true,   // Check against strict whitespace and indentation rules.
+    "indent"        : 0       // Specify indentation spacing
+}
